UseObjectInitializerTests.cs

// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
 
using System.Threading.Tasks;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.UseObjectInitializer;
using Microsoft.CodeAnalysis.Editor.UnitTests.CodeActions;
using Microsoft.CodeAnalysis.Test.Utilities;
using Roslyn.Test.Utilities;
using Xunit;
 
namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.UseObjectInitializer
{
    using VerifyCS = CSharpCodeFixVerifier<
        CSharpUseObjectInitializerDiagnosticAnalyzer,
        CSharpUseObjectInitializerCodeFixProvider>;
 
    [Trait(Traits.Feature, Traits.Features.CodeActionsUseObjectInitializer)]
    public partial class UseObjectInitializerTests
    {
        private static async Task TestInRegularAndScriptAsync(string testCode, string fixedCode, OutputKind outputKind = OutputKind.DynamicallyLinkedLibrary)
        {
            await new VerifyCS.Test
            {
                TestCode = testCode,
                FixedCode = fixedCode,
                LanguageVersion = LanguageVersion.Preview,
                TestState = { OutputKind = outputKind }
            }.RunAsync();
        }
 
        private static async Task TestMissingInRegularAndScriptAsync(string testCode, LanguageVersion? languageVersion = null)
        {
            var test = new VerifyCS.Test
            {
                TestCode = testCode,
                FixedCode = testCode,
            };
 
            if (languageVersion != null)
                test.LanguageVersion = languageVersion.Value;
 
            await test.RunAsync();
        }
 
        [Fact]
        public async Task TestOnVariableDeclarator()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
 
                    void M()
                    {
                        var c = [|new|] C();
                        [|c.|]i = 1;
                    }
                }
                """,
                """
                class C
                {
                    int i;
 
                    void M()
                    {
                        var c = new C
                        {
                            i = 1
                        };
                    }
                }
                """);
        }
 
        [Fact]
        public async Task TestDoNotUpdateAssignmentThatReferencesInitializedValue1Async()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
 
                    void M()
                    {
                        var c = [|new|] C();
                        [|c.|]i = 1;
                        c.i = c.i + 1;
                    }
                }
                """,
                """
                class C
                {
                    int i;
 
                    void M()
                    {
                        var c = new C
                        {
                            i = 1
                        };
                        c.i = c.i + 1;
                    }
                }
                """);
        }
 
        [Fact]
        public async Task TestDoNotUpdateAssignmentThatReferencesInitializedValue2Async()
        {
            await TestMissingInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
 
                    void M()
                    {
                        var c = new C();
                        c.i = c.i + 1;
                    }
                }
                """);
        }
 
        [Fact]
        public async Task TestDoNotUpdateAssignmentThatReferencesInitializedValue3Async()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
 
                    void M()
                    {
                        C c;
                        c = [|new|] C();
                        [|c.|]i = 1;
                        c.i = c.i + 1;
                    }
                }
                """,
                """
                class C
                {
                    int i;
 
                    void M()
                    {
                        C c;
                        c = new C
                        {
                            i = 1
                        };
                        c.i = c.i + 1;
                    }
                }
                """);
        }
 
        [Fact]
        public async Task TestDoNotUpdateAssignmentThatReferencesInitializedValue4Async()
        {
            await TestMissingInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
 
                    void M()
                    {
                        C c;
                        c = new C();
                        c.i = c.i + 1;
                    }
                }
                """);
        }
 
        [Fact]
        public async Task TestOnAssignmentExpression()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
 
                    void M()
                    {
                        C c = null;
                        c = [|new|] C();
                        [|c.|]i = 1;
                    }
                }
                """,
                """
                class C
                {
                    int i;
 
                    void M()
                    {
                        C c = null;
                        c = new C
                        {
                            i = 1
                        };
                    }
                }
                """);
        }
 
        [Fact]
        public async Task TestStopOnDuplicateMember()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
 
                    void M()
                    {
                        var c = [|new|] C();
                        [|c.|]i = 1;
                        c.i = 2;
                    }
                }
                """,
                """
                class C
                {
                    int i;
 
                    void M()
                    {
                        var c = new C
                        {
                            i = 1
                        };
                        c.i = 2;
                    }
                }
                """);
        }
 
        [Fact]
        public async Task TestComplexInitializer()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
                    int j;
 
                    void M(C[] array)
                    {
                        array[0] = [|new|] C();
                        [|array[0].|]i = 1;
                        [|array[0].|]j = 2;
                    }
                }
                """,
                """
                class C
                {
                    int i;
                    int j;
 
                    void M(C[] array)
                    {
                        array[0] = new C
                        {
                            i = 1,
                            j = 2
                        };
                    }
                }
                """);
        }
 
        [Fact]
        public async Task TestNotOnCompoundAssignment()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
                    int j;
 
                    void M()
                    {
                        var c = [|new|] C();
                        [|c.|]i = 1;
                        c.j += 1;
                    }
                }
                """,
                """
                class C
                {
                    int i;
                    int j;
 
                    void M()
                    {
                        var c = new C
                        {
                            i = 1
                        };
                        c.j += 1;
                    }
                }
                """);
        }
 
        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/39146")]
        public async Task TestWithExistingInitializer()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
                    int j;
 
                    void M()
                    {
                        var c = [|new|] C() { i = 1 };
                        [|c.|]j = 1;
                    }
                }
                """,
                """
                class C
                {
                    int i;
                    int j;
 
                    void M()
                    {
                        var c = [||]new C
                        {
                            i = 1,
                            j = 1
                        };
                    }
                }
                """);
        }
 
        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/39146")]
        public async Task TestWithExistingInitializerComma()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
                    int j;
 
                    void M()
                    {
                        var c = [|new|] C()
                        {
                            i = 1,
                        };
                        [|c.|]j = 1;
                    }
                }
                """,
                """
                class C
                {
                    int i;
                    int j;
 
                    void M()
                    {
                        var c = [||]new C
                        {
                            i = 1,
                            j = 1
                        };
                    }
                }
                """);
        }
 
        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/39146")]
        public async Task TestWithExistingInitializerNotIfAlreadyInitialized()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
                    int j;
 
                    void M()
                    {
                        var c = [|new|] C()
                        {
                            i = 1,
                        };
                        [|c.|]j = 1;
                        c.i = 2;
                    }
                }
                """,
                """
                class C
                {
                    int i;
                    int j;
 
                    void M()
                    {
                        var c = [||]new C
                        {
                            i = 1,
                            j = 1
                        };
                        c.i = 2;
                    }
                }
                """);
        }
 
        [Fact]
        public async Task TestMissingBeforeCSharp3()
        {
            await TestMissingInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
                    int j;
 
                    void M()
                    {
                        C c = new C();
                        c.j = 1;
                    }
                }
                """, LanguageVersion.CSharp2);
        }
 
        [Fact]
        public async Task TestFixAllInDocument1()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
                    int j;
 
                    public C() { }
                    public C(System.Action a) { }
 
                    void M()
                    {
                        var v = [|new|] C(() => {
                            var v2 = [|new|] C();
                            [|v2.|]i = 1;
                        });
                        [|v.|]j = 2;
                    }
                }
                """,
                """
                class C
                {
                    int i;
                    int j;
 
                    public C() { }
                    public C(System.Action a) { }
 
                    void M()
                    {
                        var v = new C(() =>
                        {
                            var v2 = new C
                            {
                                i = 1
                            };
                        })
                        {
                            j = 2
                        };
                    }
                }
                """);
        }
 
        [Fact]
        public async Task TestFixAllInDocument2()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
                    System.Action j;
 
                    void M()
                    {
                        var v = [|new|] C();
                        [|v.|]j = () => {
                            var v2 = [|new|] C();
                            [|v2.|]i = 1;
                        };
                    }
                }
                """,
                """
                class C
                {
                    int i;
                    System.Action j;
 
                    void M()
                    {
                        var v = new C
                        {
                            j = () =>
                            {
                                var v2 = new C
                                {
                                    i = 1
                                };
                            }
                        };
                    }
                }
                """);
        }
 
        [Fact]
        public async Task TestFixAllInDocument3()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
                    int j;
 
                    void M(C[] array)
                    {
                        array[0] = [|new|] C();
                        [|array[0].|]i = 1;
                        [|array[0].|]j = 2;
                        array[1] = [|new|] C();
                        [|array[1].|]i = 3;
                        [|array[1].|]j = 4;
                    }
                }
                """,
                """
                class C
                {
                    int i;
                    int j;
 
                    void M(C[] array)
                    {
                        array[0] = new C
                        {
                            i = 1,
                            j = 2
                        };
                        array[1] = new C
                        {
                            i = 3,
                            j = 4
                        };
                    }
                }
                """);
        }
 
        [Fact]
        public async Task TestTrivia1()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
                    int j;
                    void M()
                    {
                        var c = [|new|] C();
                        [|c.|]i = 1; // Goo
                        [|c.|]j = 2; // Bar
                    }
                }
                """,
                """
                class C
                {
                    int i;
                    int j;
                    void M()
                    {
                        var c = new C
                        {
                            i = 1, // Goo
                            j = 2 // Bar
                        };
                    }
                }
                """);
        }
 
        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/46670")]
        public async Task TestTriviaRemoveLeadingBlankLinesForFirstProperty()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
                    int j;
                    void M()
                    {
                        var c = [|new|] C();
 
                        //Goo
                        [|c.|]i = 1;
 
                        //Bar
                        [|c.|]j = 2;
                    }
                }
                """,
                """
                class C
                {
                    int i;
                    int j;
                    void M()
                    {
                        var c = new C
                        {
                            //Goo
                            i = 1,
 
                            //Bar
                            j = 2
                        };
                    }
                }
                """);
        }
 
        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/15459")]
        public async Task TestMissingInNonTopLevelObjectInitializer()
        {
            await TestMissingInRegularAndScriptAsync(
                """
                class C {
                	int a;
                	C Add(int x) {
                		var c = Add(new int());
                		c.a = 1;
                		return c;
                	}
                }
                """);
        }
 
        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/17853")]
        public async Task TestMissingForDynamic()
        {
            await TestMissingInRegularAndScriptAsync(
                """
                using System.Dynamic;
 
                class C
                {
                    void Goo()
                    {
                        dynamic body = new ExpandoObject();
                        body.content = new ExpandoObject();
                    }
                }
                """);
        }
 
        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/17953")]
        public async Task TestMissingAcrossPreprocessorDirective()
        {
            await TestMissingInRegularAndScriptAsync(
                """
                public class Goo
                {
                    public void M()
                    {
                        var goo = new Goo();
                #if true
                        goo.Value = "";
                #endif
                    }
 
                    public string Value { get; set; }
                }
                """);
        }
 
        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/17953")]
        public async Task TestAvailableInsidePreprocessorDirective()
        {
            await TestInRegularAndScriptAsync(
                """
                public class Goo
                {
                    public void M()
                    {
                #if true
                        var goo = [|new|] Goo();
                        [|goo.|]Value = "";
                #endif
                    }
 
                    public string Value { get; set; }
                }
                """,
                """
                public class Goo
                {
                    public void M()
                    {
                #if true
                        var goo = new Goo
                        {
                            Value = ""
                        };
                #endif
                    }
 
                    public string Value { get; set; }
                }
                """);
        }
 
        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/19253")]
        public async Task TestKeepBlankLinesAfter()
        {
            await TestInRegularAndScriptAsync(
                """
                class Goo
                {
                    public int Bar { get; set; }
                }
 
                class MyClass
                {
                    public void Main()
                    {
                        var goo = [|new|] Goo();
                        [|goo.|]Bar = 1;
 
                        int horse = 1;
                    }
                }
                """,
                """
                class Goo
                {
                    public int Bar { get; set; }
                }
 
                class MyClass
                {
                    public void Main()
                    {
                        var goo = new Goo
                        {
                            Bar = 1
                        };
 
                        int horse = 1;
                    }
                }
                """);
        }
 
        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/23368")]
        public async Task TestWithExplicitImplementedInterfaceMembers1()
        {
            await TestMissingInRegularAndScriptAsync(
                """
                interface IExample {
                    string Name { get; set; }
                }
 
                class C : IExample {
                    string IExample.Name { get; set; }
                }
 
                class MyClass
                {
                    public void Main()
                    {
                        IExample e = new C();
                        e.Name = string.Empty;
                    }
                }
                """);
        }
 
        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/23368")]
        public async Task TestWithExplicitImplementedInterfaceMembers2()
        {
            await TestMissingInRegularAndScriptAsync(
                """
                interface IExample {
                    string Name { get; set; }
                    string LastName { get; set; }
                }
 
                class C : IExample {
                    string IExample.Name { get; set; }
                    public string LastName { get; set; }
                }
 
                class MyClass
                {
                    public void Main()
                    {
                        IExample e = new C();
                        e.Name = string.Empty;
                        e.LastName = string.Empty;
                    }
                }
                """);
        }
 
        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/23368")]
        public async Task TestWithExplicitImplementedInterfaceMembers3()
        {
            await TestInRegularAndScriptAsync(
                """
                interface IExample {
                    string Name { get; set; }
                    string LastName { get; set; }
                }
 
                class C : IExample {
                    string IExample.Name { get; set; }
                    public string LastName { get; set; }
                }
 
                class MyClass
                {
                    public void Main()
                    {
                        IExample e = [|new|] C();
                        [|e.|]LastName = string.Empty;
                        e.Name = string.Empty;
                    }
                }
                """,
                """
                interface IExample {
                    string Name { get; set; }
                    string LastName { get; set; }
                }
 
                class C : IExample {
                    string IExample.Name { get; set; }
                    public string LastName { get; set; }
                }
 
                class MyClass
                {
                    public void Main()
                    {
                        IExample e = new C
                        {
                            LastName = string.Empty
                        };
                        e.Name = string.Empty;
                    }
                }
                """);
        }
 
        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/37675")]
        public async Task TestDoNotOfferForUsingDeclaration()
        {
            await TestMissingInRegularAndScriptAsync(
                """
                class C : System.IDisposable
                {
                    int i;
 
                    void M()
                    {
                        using var c = new C();
                        c.i = 1;
                    }
 
                    public void Dispose()
                    {
                    }
                }
                """);
        }
 
        [Fact]
        public async Task TestImplicitObject()
        {
            await TestInRegularAndScriptAsync(
                """
                class C
                {
                    int i;
 
                    void M()
                    {
                        C c = [|new|]();
                        [|c.|]i = 1;
                    }
                }
                """,
                """
                class C
                {
                    int i;
 
                    void M()
                    {
                        C c = new()
                        {
                            i = 1
                        };
                    }
                }
                """);
        }
 
        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/61066")]
        public async Task TestInTopLevelStatements()
        {
            await TestInRegularAndScriptAsync(
                """
                MyClass cl = [|new|]();
                [|cl.|]MyProperty = 5;
 
                class MyClass
                {
                    public int MyProperty { get; set; }
                }
                """,
                """
                MyClass cl = new()
                {
                    MyProperty = 5
                };
 
                class MyClass
                {
                    public int MyProperty { get; set; }
                }
                """, OutputKind.ConsoleApplication);
        }
    }
}
File: UseObjectInitializerTests.cs	Web Access
Project: ..\..\..\src\CodeStyle\CSharp\Tests\Microsoft.CodeAnalysis.CSharp.CodeStyle.UnitTests.csproj (Microsoft.CodeAnalysis.CSharp.CodeStyle.UnitTests)